Re: Confusing comment in xlog.c or am I missing something? - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Confusing comment in xlog.c or am I missing something?
Date
Msg-id 51820734.4030808@vmware.com
Whole thread Raw
In response to Re: Confusing comment in xlog.c or am I missing something?  (Amit Langote <amitlangote09@gmail.com>)
Responses Re: Confusing comment in xlog.c or am I missing something?  (Amit Langote <amitlangote09@gmail.com>)
List pgsql-hackers
On 02.05.2013 09:11, Amit Langote wrote:
> In that case, should the comment be "/* Check for crossing of xlog
> file boundary */"
> instead of  /* Check for crossing of xlog segment boundary */, since
> ( RecPtr->xrecoff>= XLogFileSize )
> would mean crossing the xlog "file" (not segment) boundary, right?

Yeah, that would be more correct. The phrase we seem to use elsewhere in 
xlog.c is "crossing a logid boundary".

- Heikki



pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: Confusing comment in xlog.c or am I missing something?
Next
From: Pavan Deolasee
Date:
Subject: Re: Confusing long option in pg_receivexlog/basebackup/dumpall