Re: [COMMITTERS] pgsql: Allow external recovery_config_directory - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: [COMMITTERS] pgsql: Allow external recovery_config_directory
Date
Msg-id 51531D3C.70600@vmware.com
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Allow external recovery_config_directory  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: [COMMITTERS] pgsql: Allow external recovery_config_directory
Re: [COMMITTERS] pgsql: Allow external recovery_config_directory
Re: [COMMITTERS] pgsql: Allow external recovery_config_directory
List pgsql-hackers
On 27.03.2013 18:10, Simon Riggs wrote:
> On 27 March 2013 15:35, Heikki Linnakangas<hlinnakangas@vmware.com>  wrote:
>> Ok, cool. Can you please revert this commit so that we can move on, then?
>
> Please explain why you want this reverted, without mentioning the
> other task we agree is required.

If an admin can't trust that the file is placed in $PGDATA, it's harder 
to determine if a server is a master or a standby. It makes tools that 
try to promote / demote a server more complicated, because they need to 
take this setting into account. Lastly, it breaks the new pg_basebackup 
-R functionality; pg_basebackup will create the recovery.conf file, but 
it won't take effect.
From a process standpoint, this is a new feature that should've been 
submitted before the commitfest deadline. I'm sure we'll make exceptions 
to that every now and then, but by default new features should be bumped 
to the next release at this point.

- Heikki



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: [COMMITTERS] pgsql: Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt.
Next
From: Tom Lane
Date:
Subject: Re: money with 4 digits after dot