Re: Limit usage of tcop/dest.h - Mailing list pgsql-patches

From Tom Lane
Subject Re: Limit usage of tcop/dest.h
Date
Msg-id 5150.1130941215@sss.pgh.pa.us
Whole thread Raw
In response to Limit usage of tcop/dest.h  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Limit usage of tcop/dest.h  (Bruce Momjian <pgman@candle.pha.pa.us>)
Re: Limit usage of tcop/dest.h  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-patches
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> So instead of changing the names of the CommandDest enum, I'm hiding it
> from external view.

I thought renaming them was a better idea, actually.  A whole separate
include file to have one forward typedef seems pretty silly.  Nor am I
convinced that you won't break some people's code by removing the rest
of dest.h from spi.h.  Finally, for anyone who *does* need to include
dest.h, this doesn't address the underlying problem of risk of conflict
of names.

            regards, tom lane

pgsql-patches by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Limit usage of tcop/dest.h
Next
From: Tom Lane
Date:
Subject: Re: tsearch2 makefile fixes