Re: Limit usage of tcop/dest.h - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Limit usage of tcop/dest.h
Date
Msg-id 200511021522.jA2FMKQ17622@candle.pha.pa.us
Whole thread Raw
In response to Re: Limit usage of tcop/dest.h  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Limit usage of tcop/dest.h  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-patches
Tom Lane wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > So instead of changing the names of the CommandDest enum, I'm hiding it
> > from external view.
>
> I thought renaming them was a better idea, actually.  A whole separate
> include file to have one forward typedef seems pretty silly.  Nor am I
> convinced that you won't break some people's code by removing the rest
> of dest.h from spi.h.  Finally, for anyone who *does* need to include
> dest.h, this doesn't address the underlying problem of risk of conflict
> of names.

Does the change make building PL/PHP easier?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: tsearch2 makefile fixes
Next
From: Alvaro Herrera
Date:
Subject: Re: Limit usage of tcop/dest.h