Re: pgsql: Replace existing durable_rename_excl() calls with durable_rename - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Replace existing durable_rename_excl() calls with durable_rename
Date
Msg-id 511362.1651116498@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Replace existing durable_rename_excl() calls with durable_rename  (Michael Paquier <michael@paquier.xyz>)
Responses Re: pgsql: Replace existing durable_rename_excl() calls with durable_rename  (Michael Paquier <michael@paquier.xyz>)
List pgsql-committers
Michael Paquier <michael@paquier.xyz> writes:
> This change replaces all calls to durable_rename_excl() with
> durable_rename().  This removes the protection against accidentally
> overwriting an existing file, but some platforms are already living
> without it, and all those code paths never expect an existing file (a
> couple of assertions are added to check after that, in case).

Assert'ing that an external (filesystem) condition holds seems like a bad
idea.  See buildfarm.

            regards, tom lane



pgsql-committers by date:

Previous
From: John Naylor
Date:
Subject: pgsql: Fix SQL syntax in comment in logical/worker.c
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Replace existing durable_rename_excl() calls with durable_rename