On 11/16/12 9:03 AM, Merlin Moncure wrote:
> Atri ran some quick n dirty tests to see if there
> were any regressions. He benched a large scan followed by vacuum. So
> far, results are inconclusive so better testing methodologies will
> definitely be greatly appreciated. One of the challenges with working
> in this part of the code is that it's quite difficult to make changes
> without impacting at least some workloads.
I'm adding something to pgbench-tools to test for some types of vacuum
regressions that I've seen before. And the checksum benchmarking I've
already signed up for overlaps with this one quite a bit. I'd suggest
reviewers here focus on code quality, correctness, and targeted
optimization testing. I'm working heavily on a larger benchmarking
framework that both this and checksums will fit into right now.
--
Greg Smith 2ndQuadrant US greg@2ndQuadrant.com Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.com