Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Allow multiple recursive self-references - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCH] Allow multiple recursive self-references
Date
Msg-id 4fd5d5f3-e662-868b-229d-40030a487fa4@enterprisedb.com
Whole thread Raw
In response to Re: [PATCH] Allow multiple recursive self-references  (Denis Hirn <denis.hirn@uni-tuebingen.de>)
Responses Re: [PATCH] Allow multiple recursive self-references  (Denis Hirn <denis.hirn@uni-tuebingen.de>)
List pgsql-hackers
Tree view 
On 20.07.21 13:15, Denis Hirn wrote:
>> In the next version of the patch, would you be so kind as to include
>> updated documentation of the feature and at least one regression test
>> of same?
> 
> As requested, this new version of the patch contains regression tests and documentation.

The tests fail when you build with assertions enabled (configure 
--enable-cassert).

Some quick style comments:

DocBook content should use 1-space indentation (not 2 spaces).

Typo?: /* we'll see this later */ -> "set"

Opening brace after "if" should be on new line.  (See existing code.)

Also, there should be a space after "if".

These casts appear to be unnecessary:

     if((Node *) stmt->larg != NULL && (Node *) stmt->rarg != NULL)

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o
Next
From: Andres Freund
Date:
Subject: Re: pgstat_send_connstats() introduces unnecessary timestamp and UDP overhead