Re: libpq compression (part 2) - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: libpq compression (part 2)
Date
Msg-id 4fab82d1-a0f5-0d01-4d6c-0b780b5eea3a@enterprisedb.com
Whole thread Raw
In response to Re: libpq compression (part 2)  (Andrey Borodin <amborodin86@gmail.com>)
Responses Re: libpq compression (part 2)
List pgsql-hackers
On 17.11.22 01:27, Andrey Borodin wrote:
> Also I've found one more TODO item for the patch. Currently in
> fe-connect.c patch is doing buffer reset:
> conn->inStart = conn->inCursor = conn->inEnd = 0;
> This effectively consumes butes up tu current cursor. However, packet
> inspection is continued. The patch works because in most cases
> following code will issue re-read of message. Coincidentally.
> /* Get the type of request. */
> if (pqGetInt((int *) &areq, 4, conn))
> {
> /* We'll come back when there are more data */
> return PGRES_POLLING_READING;
> }

Note that the above code was just changed in dce92e59b1.  I don't know 
how that affects this patch set.




pgsql-hackers by date:

Previous
From: Japin Li
Date:
Subject: Re: redundant check of msg in does_not_exist_skipping
Next
From: Japin Li
Date:
Subject: Re: redundant check of msg in does_not_exist_skipping