Re: archive modules - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: archive modules
Date
Msg-id 4f66de67-35a0-3fe7-fa61-d618e1bd2c2c@enterprisedb.com
Whole thread Raw
In response to Re: archive modules  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: archive modules  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
On 23.09.22 18:14, Nathan Bossart wrote:
> On Fri, Sep 23, 2022 at 05:58:42AM -0400, Peter Eisentraut wrote:
>> On 15.09.22 00:27, Nathan Bossart wrote:
>>> Both archive_command and archive_library are PGC_SIGHUP, so IIUC that
>>> wouldn't be sufficient.  I attached a quick sketch that seems to provide
>>> the desired behavior.  It's nowhere near committable yet, but it
>>> demonstrates what I'm thinking.
>>
>> What is the effect of issuing a warning like in this patch?  Would it just
>> not archive anything until the configuration is fixed?  I'm not sure what
>> behavior you are going for; it's a bit hard to imagine from just reading the
>> patch.
> 
> Yes, it will halt archiving and emit a WARNING, just like what happens on
> released versions when you leave archive_command empty.

Leaving archive_command empty is an intentional configuration choice.

What we are talking about here is, arguably, a misconfiguration, so it 
should result in an error.




pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: installcheck-world concurrency issues
Next
From: Alvaro Herrera
Date:
Subject: Re: Move backup-related code to xlogbackup.c/.h