Re: BUG #17288: PSQL bug with COPY command (Windows) - Mailing list pgsql-bugs

From Dmitry Koval
Subject Re: BUG #17288: PSQL bug with COPY command (Windows)
Date
Msg-id 4c22d38f-efa9-4d83-c551-707f1770e585@postgrespro.ru
Whole thread Raw
In response to Re: BUG #17288: PSQL bug with COPY command (Windows)  (Michael Paquier <michael@paquier.xyz>)
Responses Re: BUG #17288: PSQL bug with COPY command (Windows)
List pgsql-bugs
 >I still think that we should not call GetFileInformationByHandle()
 >when it comes to an argument that we know will fail, ...

Our program calls function freopen() (this function is used in file
src\backend\utils\error\elog.c). So we don't know exactly that
GetFileInformationByHandle() will fails for stdin/stdout/stderr.

Ior illustration, I attached small example (test.c) for this case:
1) GetFileInformationByHandle() for "stdout" works without error;
2) file "1.txt" after running test contains:

Sample string
attributes = 0x2020, file size = 15

 >Each fileno is going to be 0, 1 or 2 in those cases, still
 >it would be better to rely on the result of fileno() as v3 is
 >doing?

I think fileno() is safer. We can call fclose(stdout) and
_fileno(stdout) returns -1 after that. But I don't know:
can OS reuse fileno=1 or not in this case?

With best regards,
Dmitry.
Attachment

pgsql-bugs by date:

Previous
From: Andrey Borodin
Date:
Subject: Re: conchuela timeouts since 2021-10-09 system upgrade
Next
From: Thomas Munro
Date:
Subject: Re: conchuela timeouts since 2021-10-09 system upgrade