Re: [COMMITTERS] pgsql: Logical replication support for initial datacopy - Mailing list pgsql-committers

From Peter Eisentraut
Subject Re: [COMMITTERS] pgsql: Logical replication support for initial datacopy
Date
Msg-id 4b7aa38b-3849-0b62-8266-c4fbaa6c691e@2ndquadrant.com
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Logical replication support for initial datacopy  (Petr Jelinek <petr.jelinek@2ndquadrant.com>)
Responses Re: pgsql: Logical replication support for initial data copy
List pgsql-committers
On 3/23/17 10:25, Petr Jelinek wrote:
> On 23/03/17 15:17, Stephen Frost wrote:
>> Petr,
>>
>> * Petr Jelinek (petr.jelinek@2ndquadrant.com) wrote:
>>> On 23/03/17 14:47, Petr Jelinek wrote:
>>>> I am looking into buildfarm failures.
>>>>
>>>> Looks like the clang issue (mylodon, longfin) is because we are missing
>>>> extern in include/replication/worker_internal.h for ApplyCacheContext.
>>>>
>>>> Still analyzing the rest.
>>>
>>> Ah missing fields in copy/equal function for AlterSubscriptionStmt.
>>>
>>> Attached patch adds the above mentioned extern and fixes the copy and
>>> equal functions.
>>
>> Pretty sure I saw a complaint about a trailing comma in a struct or enum
>> too..
>>
>
> Ah, missed that in the wall of text, thanks, fixed that too.

Also fixed.

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: [COMMITTERS] pgsql: Remove trailing comma from enum definition
Next
From: Teodor Sigaev
Date:
Subject: [COMMITTERS] pgsql: Reduce page locking in GIN vacuum