Re: Escape output of pg_amcheck test - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Escape output of pg_amcheck test
Date
Msg-id 4b3042f2-a8fa-4a88-8a06-2d0a6ffa99c8@eisentraut.org
Whole thread Raw
In response to Re: Escape output of pg_amcheck test  (Aleksander Alekseev <aleksander@timescale.com>)
Responses Re: Escape output of pg_amcheck test
List pgsql-hackers
On 08.01.24 15:04, Aleksander Alekseev wrote:
>> [...] so I quickly wrote some (wrong) instrumentation to try to test your patch.
> 
> Yep, it confused me too at first.
> 
> Since the encoding happens right before exit() call, maybe it's worth
> changing $b in-place in order to make the code slightly more readable
> for most of us :)

My patch originally had the old-style

my $b_escaped = $b;
$b_escaped =~ s/.../;

... sprintf(..., $b_escaped);

but then I learned about the newish /r modifier and thought it was 
cooler. :)



pgsql-hackers by date:

Previous
From: Adam S
Date:
Subject: INSERT performance: less CPU when no indexes or triggers
Next
From: Alvaro Herrera
Date:
Subject: Re: SLRU optimization - configurable buffer pool and partitioning the SLRU lock