Postgres Pro
Downloads
Home   >   mailing lists

Re: [18] Unintentional behavior change in commit e9931bfb75 - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: [18] Unintentional behavior change in commit e9931bfb75
Date
Msg-id 4ae32f53f2ddbc99824fc0a53b07cb93f09c9c09.camel@j-davis.com
Whole thread Raw
In response to Re: [18] Unintentional behavior change in commit e9931bfb75  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [18] Unintentional behavior change in commit e9931bfb75
List pgsql-hackers
Tree view 
On Mon, 2024-12-02 at 17:25 -0500, Tom Lane wrote:
> Well, also for compatibility with our SQL parser's understanding
> of identifier lowercasing.

But why only for single-byte encodings? And why not for ICU?

> > Should I put the special case back?
>
> I think so.

Done. I put the special case back in (commit e3fa2b037c) because the
earlier commit wasn't intended to be a behavior change.

I'm still not convinced that the special case behavior is great, but a
lot of users are unaffected because they are on UTF8 anyway, so I'm
fine keeping it.

Regards,
    Jeff Davis

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Memory leak in WAL sender with pgoutput (v10~)
Next
From: Tom Lane
Date:
Subject: Re: [18] Unintentional behavior change in commit e9931bfb75