Re: [PATCH] Identify LWLocks in tracepoints - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCH] Identify LWLocks in tracepoints
Date
Msg-id 4a0ca956-f2eb-ee72-4639-eca3b48f1f49@enterprisedb.com
Whole thread Raw
In response to Re: [PATCH] Identify LWLocks in tracepoints  (Andres Freund <andres@anarazel.de>)
Responses Re: [PATCH] Identify LWLocks in tracepoints
List pgsql-hackers
On 05.05.21 00:15, Andres Freund wrote:
> I'm now getting
> 
> /home/andres/src/postgresql/src/backend/storage/lmgr/lwlock.c: In function ‘LWLockAcquire’:
> /home/andres/src/postgresql/src/backend/storage/lmgr/lwlock.c:1322:58: warning: suggest braces around empty body in
an‘if’ statement [-Wempty-body]
 
>   1322 |    TRACE_POSTGRESQL_LWLOCK_WAIT_START(T_NAME(lock), mode);
>        |                                                          ^

For clarification, -Wempty-body is not part of the default warnings, right?

And even if I turn it on explicitly, I don't get this warning.  I read 
something that newer compilers don't warn in cases of macro expansion.

What compiler are you using in this situation?




pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: Small issues with CREATE TABLE COMPRESSION
Next
From: Pavel Stehule
Date:
Subject: Re: plan with result cache is very slow when work_mem is not enough