Re: xlog location arithmetic - Mailing list pgsql-hackers

From Euler Taveira de Oliveira
Subject Re: xlog location arithmetic
Date
Msg-id 4F3441FE.1020008@timbira.com
Whole thread Raw
In response to Re: xlog location arithmetic  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: xlog location arithmetic
List pgsql-hackers
On 08-02-2012 09:35, Fujii Masao wrote:

Fujii, new patch attached. Thanks for your tests.

> But another problem happened. When I changed pg_proc.h so that the unused
> OID was assigned to pg_xlog_location_diff(), and executed the above again,
> I encountered the segmentation fault:
>
I reproduced the problems in my old 32-bit laptop. I fixed it casting to
int64. I also updated the duplicated OID.

> Why OID needs to be reassigned?
>
There isn't a compelling reason. It is just a way to say: "hey, it is another
function with the same old name".

I'll not attach another version for pg_size_pretty because it is a matter of
updating a duplicated OID.


--
   Euler Taveira de Oliveira - Timbira       http://www.timbira.com.br/
   PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Attachment

pgsql-hackers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: Re: psql tab completion for SELECT
Next
From: Tom Lane
Date:
Subject: Patch: fix pg_dump for inherited defaults & not-null flags