Re: PL/Perl Does not Like vstrings - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: PL/Perl Does not Like vstrings
Date
Msg-id 4F04F871.40502@dunslane.net
Whole thread Raw
In response to Re: PL/Perl Does not Like vstrings  ("David E. Wheeler" <david@justatheory.com>)
Responses Re: PL/Perl Does not Like vstrings  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

On 01/04/2012 06:15 PM, David E. Wheeler wrote:
> [11:12pm]TonyC:theory: using sv_mortalcopy() instead of newSVsv() 
> should prevent the leak in that workaround, assuming there's no 
> FREETMPS between the call and use of the return value

That's the solution to leakiness I had in mind.

Tom said:

> 2. A slightly cleaner fix for this should be to duplicate the SV and
> then release the copy around the SvPVutf8 call, only if it's readonly.
> "Fixing" it in do_util_elog is entirely the wrong thing.

How do we tell if it's readonly?

cheers

andrew




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_restore direct to database is broken for --insert dumps
Next
From: Tom Lane
Date:
Subject: Re: PL/Perl Does not Like vstrings