Re: psycopg2.connect change from a C function to module method - Mailing list psycopg

From Federico Di Gregorio
Subject Re: psycopg2.connect change from a C function to module method
Date
Msg-id 4EF98674.6030804@dndg.it
Whole thread Raw
In response to psycopg2.connect change from a C function to module method  (Jan Urbański <wulczer@wulczer.org>)
List psycopg
On 27/12/11 00:29, Jan Urbański wrote:
> the change that made psycopg2.connect a module-level Python function
> rather than a function exposed from a C module turned ou to be
> backwards-incompatible.
>
> Attached is a small snippet that works well with psycopg2 2.4.2 and
> tracebacks with "TypeError: argument 1 must be string, not C" with 2.4.3.
>
> The potential for actual breakage is very small, but I wanted to report
> it in case someone hits it like I did and perhaps to discuss whether the
> fix I applied is correct.
>
> This was first reported to me by users of txpostgres, which got broken
> by the connect() changes. The fix I applied is:
>
> https://github.com/wulczer/txpostgres/commit/b9ffbbd72cff261da5d37d76a2c1e9f099848014

The fix seems correct to me. I guess if it is possible to tell Python
that the connect function shouldn't be treated as an instance method
directly in psycopg2.py.

federico


psycopg by date:

Previous
From: Jan Urbański
Date:
Subject: psycopg2.connect change from a C function to module method
Next
From: Daniele Varrazzo
Date:
Subject: Re: psycopg2.connect change from a C function to module method