Re: new compiler warnings - Mailing list pgsql-hackers

From Kevin Grittner
Subject Re: new compiler warnings
Date
Msg-id 4E9D874302000025000421B1@gw.wicourts.gov
Whole thread Raw
In response to Re: new compiler warnings  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: new compiler warnings  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> wrote:
> My dim recollection is that Tom and I and maybe some others did
> tests on a bunch of platforms at the time we introduced the
> protocol to make sure it did work this way, since it's crucial to
> making sure we don't get interleaved log lines.
Testing is good; I like testing.  But I've seen people code to
implementation details in such a way that things worked fine until
the next release of a product, when the implementation changed.  I
was surprised to see Tom, who is normally such a stickler for doing
such things correctly, apparently going the other way this time; but
it turns out that he had noted a guarantee in the API that I'd
missed.  Mystery solved.
Perhaps something in the comments would help people avoid making the
same mistake I did.
-Kevin


pgsql-hackers by date:

Previous
From: "Kevin Grittner"
Date:
Subject: Re: new compiler warnings
Next
From: Tom Lane
Date:
Subject: Re: (patch) regression diffs on collate.linux.utf8 test