Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> wrote:
>> Attached is also a patch to fix those, so that all permutations
>> work.
>
> I think that needs some explanation, why only those
> SxactIsCommitted() tests need to be replaced with
> SxactIsPrepared()? What about the first SxactIsCommitted() test in
> OnConflict_CheckForSerializationFailure(), for instance?
Well, that's covered in the other patch. This one has the minimum
required to get all the permutations of 2PC working correctly. It
was looking at just such questions as you pose here that led us to
the other patch. Neither macro has quite the right semantics
without the lower level work in the "atomic commit" patch.
-Kevin
