Re: Error in PQsetvalue - Mailing list pgsql-hackers

From Andrew Chernow
Subject Re: Error in PQsetvalue
Date
Msg-id 4DE997D2.7070103@esilo.com
Whole thread Raw
In response to Re: Error in PQsetvalue  (Andrew Chernow <ac@esilo.com>)
Responses Re: Error in PQsetvalue
List pgsql-hackers
>> I disagree -- I think the fix is a one-liner. line 446:
>> if (tup_num == res->ntups&& !res->tuples[tup_num])
>>
>> should just become
>> if (tup_num == res->ntups)
>>
>> also the memset of the tuple slots when the slot array is expanded can
>> be removed. (in addition, the array tuple array expansion should
>> really be abstracted, but that isn't strictly necessary here).
>>
>
> All true. This is a cleaner fix to something that was in fact broken ;) You want

Attached a patch that fixes the OP's issue.  PQsetvalue now uses pqAddTuple to
grow the tuple table and has removed the remnants of an older idea that caused
the bug.

--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/

Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Remove support for 'userlocks'?
Next
From: Andrew Chernow
Date:
Subject: Re: Error in PQsetvalue