Re: MMAP Buffers - Mailing list pgsql-hackers

From Greg Smith
Subject Re: MMAP Buffers
Date
Msg-id 4DAA23F9.8030504@2ndquadrant.com
Whole thread Raw
In response to Re: MMAP Buffers  (Radosław Smogura <rsmogura@softperience.eu>)
List pgsql-hackers
Radosław Smogura wrote:
> Yes, but, hmm... in Netbeans I had really long gaps (probably 8 
> spaces, from tabs), so deeper "ifs", comments at the and of variables, 
> went of out my screen. I really wanted to not format this, but 
> sometimes I needed.

The guide at 
http://www.open-source-editor.com/editors/how-to-make-netbeans-use-tabs-for-indention.html 
seems to cover how to fix this in Netbeans.  You want it to look like 
that screen shot:  4 spaces per indent with matching tab size of 4, and 
"Expand Tabs to Spaces" unchecked.

Generally, if you look at the diff you've created, and your new code 
doesn't line up right with what's already there, that means the 
tab/space setup isn't quite right when you were editing.  Reading the 
diff is useful for catching all sorts of other issues, too, so it's just 
generally a good practice.  As Peter already mentioned, the big problem 
here is that you checked in a modified configure file.

I also note that you use C++ style "//" comments, which aren't allowed 
under the coding guidelines--even though they work fine on many common 
platforms.

-- 
Greg Smith   2ndQuadrant US    greg@2ndQuadrant.com   Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support  www.2ndQuadrant.us




pgsql-hackers by date:

Previous
From: Thom Brown
Date:
Subject: Re: ALTER TABLE INHERIT vs collations
Next
From: Tom Lane
Date:
Subject: Re: MMAP Buffers