Disable optimization when in subtransaction - Mailing list pgsql-hackers

From Kevin Grittner
Subject Disable optimization when in subtransaction
Date
Msg-id 4D99C9F3020000250003C229@gw.wicourts.gov
Whole thread Raw
Responses Re: Disable optimization when in subtransaction  ("Kevin Grittner" <Kevin.Grittner@wicourts.gov>)
List pgsql-hackers
When I was investigating this report:

http://archives.postgresql.org/pgsql-bugs/2011-03/msg00349.php

besides providing a straightforward fix here:

http://archives.postgresql.org/pgsql-bugs/2011-03/msg00352.php

I noted that there was nearby code which needed review, as it didn't
seem safe when in a subtransaction.  Further review confirmed this
and didn't turn up any other problems in that section of code.  So,
a fix for this overreaching optimization is attached.  Note that it
is a one-line fix except for some additional comments to explain the
limitation.

This patch is in addition to and orthogonal to the first patch cited
above.

I will add this one to the 9.1 open items list.

-Kevin


Attachment

pgsql-hackers by date:

Previous
From: Dan Ports
Date:
Subject: Re: time table for beta1
Next
From: Tom Lane
Date:
Subject: Re: GUC assign hooks (was Re: wal_buffers = -1 and SIGHUP)