Re: Add unistd.h to c.h - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Add unistd.h to c.h
Date
Msg-id 4D7A550F.7040701@enterprisedb.com
Whole thread Raw
In response to Re: Add unistd.h to c.h  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Add unistd.h to c.h
Re: Add unistd.h to c.h
List pgsql-hackers
On 11.03.2011 18:55, Bruce Momjian wrote:
> OK, I am just asking.  FYI, we already include a boatload of includes in
> c.h:
>
>     #include<stdio.h>
>     #include<stdlib.h>
>     #include<string.h>
>     #include<stddef.h>
>     #include<stdarg.h>
>     #ifdef HAVE_STRINGS_H
>     #include<strings.h>
>     #endif
>     #ifdef HAVE_STDINT_H
>     #include<stdint.h>
>     #endif
>     #include<sys/types.h>

Presumably all of these are used by something in c.h itself. At least 
strings.h is needed by memset, and stddef.h and/or stdlib.h is needed 
for size_t. I'm too lazy to check the rest, but if there are any header 
files there that are not in fact used by anything in c.h itself, they 
should be removed from c.h, rather than going further into that direction.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Basic Recovery Control functions for use in Hot Standby. Pause,
Next
From: Alvaro Herrera
Date:
Subject: Re: Add unistd.h to c.h