Re: "Clear window" in the SQL Editor - Mailing list pgadmin-hackers

From Guillaume Lelarge
Subject Re: "Clear window" in the SQL Editor
Date
Msg-id 4CFCCA36.5000308@lelarge.info
Whole thread Raw
In response to "Clear window" in the SQL Editor  (Vinicius Santos <vinicius.santos.lista@gmail.com>)
Responses Re: "Clear window" in the SQL Editor  (Guillaume Lelarge <guillaume@lelarge.info>)
List pgadmin-hackers
Le 29/11/2010 23:35, Vinicius Santos a écrit :
> [...]
> In the SQL editor window, when the focus is outside of any text box, the
> button "clear window" does nothing.
>
> I believe that confuse the user. In this case the button should clear
> the SQL editor.
>
> Do you agree?
>
> I made this change.
>
> void frmQuery::OnClear(wxCommandEvent& ev)
> {
>     wxWindow *wnd=currentControl();
>
>     if (wnd == sqlQuery)
>         sqlQuery->ClearAll();
>     else if (wnd == msgResult)
>         msgResult->Clear();
>     else if (wnd == msgHistory)
>         msgHistory->Clear();
>     else if (wnd == scratchPad)
>         scratchPad->Clear();
> +    else
> +       sqlQuery->ClearAll();
> }
>
>
> Sorry my bad English. I am Brazilian.
> The Google translator is helping me.
>

Sorry for not answering sooner, it seems a good change to me, I need to
check it first.

Thanks for your patch.


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

pgadmin-hackers by date:

Previous
From: Guillaume Lelarge
Date:
Subject: Re: Ticket 283: Add option to request BOM write
Next
From: Guillaume Lelarge
Date:
Subject: pgAdmin III commit: Fix typo in --no-privileges option of frmRestore