Re: gSoC add MERGE command new patch -- merge_v104 - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: gSoC add MERGE command new patch -- merge_v104
Date
Msg-id 4C74B7AB.7010307@enterprisedb.com
Whole thread Raw
In response to Re: gSoC add MERGE command new patch -- merge_v104  (Andres Freund <andres@anarazel.de>)
Responses Re: gSoC add MERGE command new patch -- merge_v104
Re: gSoC add MERGE command new patch -- merge_v104
List pgsql-hackers
On 24/08/10 23:56, Andres Freund wrote:
> I have to ask one question: On a short review of the discussion and
> the patch I didn't find anything about the concurrency issues
> involved (at least nodeModifyTable.c didnt show any).

The SQL spec doesn't require MERGE to be an atomic "upsert" operation.

> Whats the plan to go forward at that subject? I think the patch needs
> to lock tables exclusively (the pg level, not access exclusive) as
> long as there is no additional handling...

Well, you can always do LOCK TABLE before calling MERGE if that's what 
you want, but I don't think doing that automatically would make people 
happy.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: KaiGai Kohei
Date:
Subject: Re: security label support, part.2
Next
From: Andrew Dunstan
Date:
Subject: Re: WIP: extensible enums