INSERT and parentheses - Mailing list pgsql-hackers

From Marko Tiikkaja
Subject INSERT and parentheses
Date
Msg-id 4BD58DB3.4070605@cs.helsinki.fi
Whole thread Raw
Responses Re: INSERT and parentheses  (Robert Haas <robertmhaas@gmail.com>)
Re: INSERT and parentheses  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Hi,

This came up on IRC today and I recall several instances of this during
the last two months or so, so I decided to send a patch.  The problem in
question occurs when you have extra parentheses in an INSERT list:

INSERT INTO foo(a,b,c) SELECT (a,b,c) FROM ..; or
INSERT INTO foo(a,b,c) VALUES((0,1,2));

Both of these give you the same error:
ERROR:  INSERT has more target columns than expressions

The first version is a lot more common and as it turns out, is sometimes
very hard to spot.  This patch attaches a HINT message to these two
cases.  The message itself could probably be a lot better, but I can't
think of anything.

Thoughts?


Regards,
Marko Tiikkaja

Attachment

pgsql-hackers by date:

Previous
From: Stefan Kaltenbrunner
Date:
Subject: Re: recovery_connections cannot start (was Re: master in standby mode croaks)
Next
From: Robert Haas
Date:
Subject: Re: recovery_connections cannot start (was Re: master in standby mode croaks)