Re: pgindent bizarreness - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: pgindent bizarreness
Date
Msg-id 4BB6A392.1000801@dunslane.net
Whole thread Raw
In response to pgindent bizarreness  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

Tom Lane wrote:
> Why has pgindent decided to screw up all the FD_SET calls in our code?
> See for example
> http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/pgstat.c.diff?r1=1.188;r2=1.189
>
>             
>   

This appears to be due to this on mingw:
   /mingw/include/winsock.h:typedef struct fd_set FD_SET;   /mingw/include/winsock2.h:typedef struct fd_set FD_SET;


We have a list of excluded symbols in the typdef finding code, which 
currently consists of this list:
   'date','interval','timestamp','ANY'

Looks like we should add 'FD_SET' to this list.

I'm actually wondering if the list of excluded symbols should go in 
pgindent rather than the typedef finding code. It would be a very simple 
change to the pgindent script.

cheers

andrew


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Compile fail, alpha5 & gcc 4.3.3 in elog.c
Next
From: Peter Eisentraut
Date:
Subject: message clarifications