Re: pgsql: Change replication connection log format to allow for a database - Mailing list pgsql-committers

From Heikki Linnakangas
Subject Re: pgsql: Change replication connection log format to allow for a database
Date
Msg-id 4BAB94DE.6080806@enterprisedb.com
Whole thread Raw
In response to pgsql: Change replication connection log format to allow for a database  (sriggs@postgresql.org (Simon Riggs))
Responses Re: pgsql: Change replication connection log format to allow for a database
List pgsql-committers
Simon Riggs wrote:
> Log Message:
> -----------
> Change replication connection log format to allow for a database
> called replication. Add host and port details, following format
> of messages in BackendInitialize().

Thanks!

I'm afraid this doesn't translate well:

> --- 222,232 ----
>        */
>       if (am_walsender)
>           ereport(LOG,
> !                 (errmsg("replication connection authorized: user=%s host=%s%s%s",
> !                         port->user_name,
> !                         port->remote_host, port->remote_port[0] ? " port=" : "",
> !                         port->remote_port)));
> !
>       else if (Log_connections)
>           ereport(LOG,
>                   (errmsg("connection authorized: user=%s database=%s",

If you want display the port (I'm not sure if it's of much interest),
I'd suggest something like:

if (port->remote_port[0])
  ereport(LOG,
    (errmsg("replication connection authorized: user=%s host=%s port=%s",
            port->user_name,
            port->remote_host,
            port->remote_port[0])));
else
  ereport(LOG,
    (errmsg("replication connection authorized: user=%s host=%s",
            port->user_name,
            port->remote_host)));


--
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Fix ginint4_queryextract() to actually do what it was intended to
Next
From: Heikki Linnakangas
Date:
Subject: Re: pgsql: Change replication connection log format to allow for a database