Re: Writeable CTEs and empty relations - Mailing list pgsql-hackers

From Marko Tiikkaja
Subject Re: Writeable CTEs and empty relations
Date
Msg-id 4B70F37C.2000808@cs.helsinki.fi
Whole thread Raw
In response to Re: Writeable CTEs and empty relations  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2010-02-09 01:09 +0200, Tom Lane wrote:
> Marko Tiikkaja <marko.tiikkaja@cs.helsinki.fi> writes:
>> I traced this down to heapam.c, which has this:
>> ...
>> This doesn't exactly work anymore since we modify the snapshot after
>> calling ExecInitScan().
> 
> So don't do that.  The executor is generally entitled to assume that
> parameters given to ExecutorStart are correct.  In particular, changing
> the snapshot after the query has started to run seems to me to ensure
> all sorts of inconsistent and undesirable behavior.

You do remember that the whole patch in its current form depends on
modifying the snapshot?


Regards,
Marko Tiikkaja


pgsql-hackers by date:

Previous
From: KaiGai Kohei
Date:
Subject: Re: Largeobject Access Controls (r2460)
Next
From: Jeff Davis
Date:
Subject: Re: Listen / Notify - what to do when the queue is full