Re: exec_execute_message crash - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: exec_execute_message crash
Date
Msg-id 4B3B4EAD.5090001@dunslane.net
Whole thread Raw
In response to Re: exec_execute_message crash  (Tatsuo Ishii <ishii@postgresql.org>)
Responses Re: exec_execute_message crash  (Tatsuo Ishii <ishii@postgresql.org>)
List pgsql-hackers

Tatsuo Ishii wrote:
> !     if (!PortalIsValid(portal) || (PortalIsValid(portal) && portal->cleanup == NULL))
>  
>   


Surely the second call to PortalIsValid() is redundant.        if (( !PortalIsValid(portal)) || portal->cleanup ==
NULL)

should do it, no?

cheers

andrew


pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: exec_execute_message crash
Next
From: Heikki Linnakangas
Date:
Subject: Re: Backup history file should be replicated in Streaming Replication?