msvc build fails in Japanese environment - Mailing list pgsql-hackers

From Hiroshi Inoue
Subject msvc build fails in Japanese environment
Date
Msg-id 4B3ABB1E.9060609@tpf.co.jp
Whole thread Raw
Responses Re: msvc build fails in Japanese environment  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Hi,

I try to build msvc version of postgres using the current cvs and
  get the following error.

  Unable to determine vcbuild version from first line of output! at
  src/tools/msvc/Solution.pm line 70.

The error comes from the following output of vcbuild /? in my
  environment.

  Microsoft(R) Visual C++ Project Builder - コマンド ライン バージョン
8.00.50727

The "Command Line Version" part is localized.
In addtion there's no space between "Mircrosoft" and "(R)".

The attahced patch fixes the error in my environment.

regards,
Hiroshi Inoue
Index: Solution.pm
===================================================================
RCS file: /projects/cvsroot/pgsql/src/tools/msvc/Solution.pm,v
retrieving revision 1.49
diff -c -r1.49 Solution.pm
*** Solution.pm    23 Dec 2009 13:27:04 -0000    1.49
--- Solution.pm    29 Dec 2009 23:47:43 -0000
***************
*** 66,72 ****
      open(P,"vcbuild /? |") || die "vcbuild command not found";
      my $line = <P>;
      close(P);
!     if ($line !~ /^Microsoft \(R\) Visual C\+\+ Project Builder - Command Line Version (\d+)\.00\.\d+/) {
         die "Unable to determine vcbuild version from first line of output!";
      }
      if ($1 == 8) { $self->{vcver} = '8.00' }
--- 66,72 ----
      open(P,"vcbuild /? |") || die "vcbuild command not found";
      my $line = <P>;
      close(P);
!     if ($line !~ /^Microsoft\s*\(R\) Visual C\+\+ Project Builder - \D+(\d+)\.00\.\d+/) {
         die "Unable to determine vcbuild version from first line of output!";
      }
      if ($1 == 8) { $self->{vcver} = '8.00' }

pgsql-hackers by date:

Previous
From: Daniel Farina
Date:
Subject: Re: [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION
Next
From: Hitoshi Harada
Date:
Subject: Re: IntArray in c.h