Simon Riggs wrote:
> All the CF manager needs to do is ensure that every patch submitted
> chalks up one review. If you think about it, we wouldn't actually need
> any rr reviewers at all then, because if we have 20 patches we would
> have 20 reviews due. So the whole scheme is self-balancing
In fact, just suggesting the guideline that everyone who submits a patch
should review one here was sufficient to pull in a number of submitters
who volunteered to do a single review as well, moving some distance
toward what you're describing. It seems we had a perception here that
joining rrreviewers "subscribed" you to doing multiple patch reviews;
I've let multiple submitters who were trying to help out know it's OK to
just grab one patch and review without even getting involved on that list.
Take a look at
https://commitfest.postgresql.org/action/commitfest_view?id=4 right
now. I've been suggesting to people that they assign themselves to the
patches they like, and it's nearing completely populated two days before
the CommitFest has even started. I have 6 reviewers that haven't been
assigned anything yet and there are only 8 unassigned patches out
there. In several cases, assigning the reviewer turned out to be quite
easy because so many submitters joined in--just assign someone who
submitted a patch in the same area.
So it far it looks sufficient to introduce the expectation that
submitters should also do a review, without even needing to make that a
firm rule. That helps increase the reviewer pool significantly,
addressing the general problem Robert has been fighting, while not
forcing people like Dave who have other pulls on their time into a
review role. We'll see whether the follow-through here is good or not,
maybe this will decay yet. For now, simply telling submitters that the
review of their own patches might be influenced by whether they do a
good job reviewing someone else's has improved things considerably over
past CommitFests, and it's hard to imagine how someone could complain
about a guideline that fair.
The most difficult part here remains finding reviewers for the really
big patches.
--
Greg Smith 2ndQuadrant Baltimore, MD
PostgreSQL Training, Services and Support
greg@2ndQuadrant.com www.2ndQuadrant.com
