Postgres Pro
Downloads
Home   >   mailing lists

Re: pgAdmin and Slony - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: pgAdmin and Slony
Date
Msg-id 4A9FC695.4050501@enterprisedb.com
Whole thread Raw
In response to pgAdmin and Slony  (Sachin Srivastava <sachin.srivastava@enterprisedb.com>)
Responses Re: pgAdmin and Slony  (Dave Page <dave.page@enterprisedb.com>)
List pgadmin-hackers
Tree view
Looks good to me..
Though not tested..
I will be able to test it tomorrow.

Dave Page wrote:
On Thu, Sep 3, 2009 at 2:08 PM, Sachin
Srivastava<sachin.srivastava@enterprisedb.com> wrote:

Dave,


- bool dlgRepCluster::SlonyMaximumVersion(wxString series, long minor)

should be:

bool dlgRepCluster::SlonyMaximumVersion(const wxString&series, long minor)


Done.

- Just reading the patch, it looks like we never try to load xxid*.sql
any more. That's surely wrong?


Yes. Attached is an updated patch.


Thanks. I've had a quick look, and it looks reasonable to me. Ashesh;
can you review it as well please?

pgadmin-hackers by date:

Previous
From: Sachin Srivastava
Date:
Subject: Re: pgAdmin and Slony
Next
From: Dave Page
Date:
Subject: Re: pgAdmin and Slony