Re: [PATCH] "could not reattach to shared memory" on Windows - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: [PATCH] "could not reattach to shared memory" on Windows
Date
Msg-id 4A5CB2D1.5070108@enterprisedb.com
Whole thread Raw
In response to Re: [PATCH] "could not reattach to shared memory" on Windows  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
>> Since this fixes a very annoying bug present in older versions, I think
>> this should be backpatched all the way back to 8.2.
> 
> Agreed, but first we need some evidence that it actually fixes the
> problem.  How can we acquire such evidence?

Apply to CVS HEAD and have people test it. I wouldn'ẗ be opposed to
back-patching to 8.4 where it would receive more testing in real life.
If we're really uneasy about it, provide a switch to turn it off if it
causes problems.

>> - please use ereport() instead of elog() for error messages
> 
> This is only appropriate if they're user-facing messages, which probably
> errors in this area are not ...

Heh, that's what we hope :-).

--  Heikki Linnakangas EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Stefan Kaltenbrunner
Date:
Subject: Re: [pgsql-www] Launching commitfest.postgresql.org
Next
From: Andrew Dunstan
Date:
Subject: Re: COPY WITH CSV FORCE QUOTE *