Re: BUG #4879: bgwriter fails to fsync the file in recovery mode - Mailing list pgsql-bugs

From Heikki Linnakangas
Subject Re: BUG #4879: bgwriter fails to fsync the file in recovery mode
Date
Msg-id 4A43DF7F.3000205@enterprisedb.com
Whole thread Raw
In response to Re: BUG #4879: bgwriter fails to fsync the file in recovery mode  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: BUG #4879: bgwriter fails to fsync the file in recovery mode
List pgsql-bugs
Tom Lane wrote:
> Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
>> Tom Lane wrote:
>>> Actually, what in the world is the purpose of that code at all?
>
>> Huh? The only other place where we advance minimum recovery point is
>> CreateRestartPoint() when we skip the restartpoint. The
>> UpdateMinRecoveryPoint() call in XLogFlush() is what we rely on.
>
> I would like an explanation of why minimum recovery point needs to
> be advanced at all.  If there's any use for it, it is surely part
> of functionality that is not there in 8.4.

It gives protection against starting up the database too early. It stops
the database from starting up if you stop recovery, and move recovery
target backwards or delete WAL files from pg_xlog, in a way that's not
safe. Of course, that's a case of "don't do that!", but it's a mistake
you can make when trying to manually recover to a given point in time.
Or if your recovery scripts are broken.

--
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com

pgsql-bugs by date:

Previous
From: Simon Riggs
Date:
Subject: Re: BUG #4879: bgwriter fails to fsync the file in recovery mode
Next
From: Dave Page
Date:
Subject: Re: BUG #4882: One-click installer crashes with certain service account passwords