Re: poor wording on SSPI error message - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: poor wording on SSPI error message
Date
Msg-id 49B19DB7.1020909@hagander.net
Whole thread Raw
In response to poor wording on SSPI error message  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: poor wording on SSPI error message  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Alvaro Herrera wrote:
> Hi,
> 
> This message
> 
>     r = (_QuerySecurityContextToken) (sspictx, &token);
>     if (r != SEC_E_OK)
>     {
>         FreeLibrary(secur32);
>         pg_SSPI_error(ERROR,
>                gettext_noop("could not get security token from context"), r);
>     }
> 
> looks poorly worded.  What "context" is it talking about?  Can we be a
> bit more explicit?  Any other thoughts on how to improve it?

Hmm. that should probalby read "could not get token from security
context", because that's what it's trying to do. But maybe you meant
something different from that as well?

/Magnus



pgsql-hackers by date:

Previous
From: "Lawrence, Ramon"
Date:
Subject: Re: Proposed Patch to Improve Performance of Multi-BatchHash Join for Skewed Data Sets
Next
From: "Kevin Grittner"
Date:
Subject: Re: Out parameters handling