Re: building pg_dump doesn't work - Mailing list pgsql-hackers

From Zdenek Kotala
Subject Re: building pg_dump doesn't work
Date
Msg-id 49AF9FDB.1010702@sun.com
Whole thread Raw
In response to Re: building pg_dump doesn't work  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: building pg_dump doesn't work  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
Dne  3.03.09 22:55, Tom Lane napsal(a):

> 
> One idea that comes to mind is to replace the entries like
> 
>     {"abort", ABORT_P, UNRESERVED_KEYWORD},
> 
> with macro calls
> 
>     PG_KEYWORD("abort", ABORT_P, UNRESERVED_KEYWORD),
> 
> and then the frontend build of the file could define the macro
> to ignore its second argument.

It sounds good.

> The way we do it now seems to have other disadvantages too: we are
> incorporating a backend .o file into pg_dump as-is, which would lead
> to large problems if there were differences in say the compiler flags
> needed.  In fact, I thought Zdenek had been working on decoupling
> that sort of thing, so I'm a bit surprised it's still like this at all.

Yeah, it is still on my TODO list. There is still problem with 
pg_resetxlog which needs lot of internals headers. :(
    Zdenek


pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: SIGHUP during recovery
Next
From: Fujii Masao
Date:
Subject: Re: SIGHUP during recovery