RE: Add Nullif case for eval_const_expressions_mutator - Mailing list pgsql-hackers

From Hou, Zhijie
Subject RE: Add Nullif case for eval_const_expressions_mutator
Date
Msg-id 4982fac6fc62459bbcf560c6302ecd47@G08CNEXMBPEKD05.g08.fujitsu.local
Whole thread Raw
In response to RE: Add Nullif case for eval_const_expressions_mutator  ("Hou, Zhijie" <houzj.fnst@cn.fujitsu.com>)
Responses Re: Add Nullif case for eval_const_expressions_mutator
List pgsql-hackers
> > I think this patch should be about a tenth the size.  Try modeling it
> > on the T_SubscriptingRef-etc case, ie, use ece_generic_processing and
> > then ece_evaluate_expr to cover the generic cases.  OpExpr is common
> > enough to deserve specially optimized code, but NullIf isn't, so shorter
> is better.
>
> Thanks for the review.
>
> Attaching v2 patch , which followed the suggestion to use
> ece_generic_processing and ece_evaluate_expr to simplify the code.
>
> Please have a check.

Sorry, I found the code still be simplified better.
Attaching the new patch.

Best regards,
houzj




Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Logical Replication - behavior of ALTER PUBLICATION .. DROP TABLE and ALTER SUBSCRIPTION .. REFRESH PUBLICATION
Next
From: Bharath Rupireddy
Date:
Subject: Fix a typo in SearchCatCache function comment