Re: Fixes for compiler warnings - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Fixes for compiler warnings
Date
Msg-id 49746B8A.4020601@hagander.net
Whole thread Raw
In response to Re: Fixes for compiler warnings  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Fixes for compiler warnings  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
Tom Lane wrote:
> Magnus, you wanna clean up the mess?  And what patch does the "few more"
> comment refer back to?
> 
> A workable solution that both silences the warning and preserves
> localizability is to follow a coding pattern like this:
> 
>     const char *mymsg = gettext_noop("Some text to be localized.");
> 
>     ...
> 
>     errmsg("%s", _(mymsg))        // not just errmsg(mymsg)

For a change like
http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c?r1=1.480&r2=1.481

Will it work to stick _(hintmsg) around it there?


//Magnus


pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Hot Standby dev build (v8)
Next
From: Simon Riggs
Date:
Subject: Re: Hot Standby dev build (v8)