Re: text search patch status update? - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: text search patch status update?
Date
Msg-id 4965AD58.5020001@enterprisedb.com
Whole thread Raw
In response to Re: text search patch status update?  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian wrote:
> Sushant Sinha wrote:
>> The default headline generation function is complicated. It checks a lot
>> of cases to determine the best headline to be displayed. So Heikki's
>> examples just say that headline generation function may not be very
>> intuitive. However, his examples were not affected by the bug.
>>
>> Because of the bug, hlcover was not returning a cover when the query
>> item was the first lexeme in the text. And so the headline generation
>> function will return just MINWORDS rather than the actual headline as
>> per the logic.
>>
>> After the patch you will see the difference in the example:
>>
>> http://archives.postgresql.org/pgsql-hackers/2008-07/msg00785.php
> 
> Ah, thank you for the clarification.  I now realize Heikki was more
> saying the code can be improved rather than reporting a bug.  Thanks.

No, it does still look wrong to me.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: KaiGai Kohei
Date:
Subject: Re: New patch for Column-level privileges
Next
From: Simon Riggs
Date:
Subject: Re: Latest version of Hot Standby patch