Re: Latest version of Hot Standby patch - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Latest version of Hot Standby patch
Date
Msg-id 496524F2.1030601@enterprisedb.com
Whole thread Raw
In response to Re: Latest version of Hot Standby patch  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: Latest version of Hot Standby patch  (Simon Riggs <simon@2ndQuadrant.com>)
List pgsql-hackers
Simon Riggs wrote:
> On Wed, 2009-01-07 at 15:43 +0200, Heikki Linnakangas wrote:
>> When there's no xids in the procarray, couldn't we just use 
>> latestCompletedXid instead of calling ReadNewTransactionId()?
> 
> latestCompletedXid is protected by ProcArrayLock so not much difference
> between those two.

The big difference is that we're already holding ProcArrayLock. You 
could read the value of latestCompletedXid before releasing 
ProcArrayLock, and wouldn't need the retry logic.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [COMMITTERS] pgsql: Adjust things so that the query_string of a cached plan and the
Next
From: Hiroshi Inoue
Date:
Subject: Re: [BUGS] BUG #4186: set lc_messages does not work