I updated patch set of SE-PostgreSQL and related stuff (r1389).
[1/5] http://sepgsql.googlecode.com/files/sepostgresql-sepgsql-8.4devel-3-r1389.patch
[2/5] http://sepgsql.googlecode.com/files/sepostgresql-utils-8.4devel-3-r1389.patch
[3/5] http://sepgsql.googlecode.com/files/sepostgresql-policy-8.4devel-3-r1389.patch
[4/5] http://sepgsql.googlecode.com/files/sepostgresql-docs-8.4devel-3-r1389.patch
[5/5] http://sepgsql.googlecode.com/files/sepostgresql-tests-8.4devel-3-r1389.patch
List of updates:
- The patches are rebased to the latest CVS HEAD, which includes generic reloptions framework by Alvaro Herrera.
- Row-level ACL's reloptions ("row_level_acl" and "default_row_acl") are reworked based on the new framework.
Alvaro, could you check the patched code on reloptions.h, reloptions.c
and rel.h? It is a working example of string reloptions, and I could
found a few strange codes.
1. HANDLE_STRING_RELOPTION() always put an empty string when optstring->default_isnull is true, even if user gives a
validstring reloption.
2. HANDLE_STRING_RELOPTION() cannot handle an offset style. The patched one enables to put reloption string on the
tailof StdRdOptions structure, and adjust offset value.
3. Why the "StdRdOptions lopts;" is necessary? A string reloption need to put it on the tail of StdRdOptions and
memberof the structure indicates its offset, so it should be allocated with variable length at the begining. The
patchedone invokes palloc0() with sizeof(StdRdOptions) and length of string at first.
And, I have a request.
4. Is it possible to support a call-back to validate a given string reloption? I want to check whether the given
default Row-level ACLs has a valid format, or not.
Thanks,
--
OSS Platform Development Division, NEC
KaiGai Kohei <kaigai@ak.jp.nec.com>
