Re: Latest version of Hot Standby patch: unexpected error querying standby - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Latest version of Hot Standby patch: unexpected error querying standby
Date
Msg-id 4960CED8.1020507@enterprisedb.com
Whole thread Raw
In response to Re: Latest version of Hot Standby patch: unexpected error querying standby  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Responses Re: Latest version of Hot Standby patch: unexpected error querying standby  (Greg Stark <greg.stark@enterprisedb.com>)
List pgsql-hackers
Heikki Linnakangas wrote:
> I can reproduce that too with CVS HEAD, so it's clearly a bug. I 
> probably introduced it with the recent smgr changes; I'll try to hunt it 
> down.

Now that was an embarrassingly simple bug:

--- a/src/backend/catalog/storage.c
+++ b/src/backend/catalog/storage.c
@@ -106,7 +106,7 @@ RelationCreateStorage(RelFileNode rnode, bool istemp)     srel = smgropen(rnode);
smgrcreate(srel,MAIN_FORKNUM, false);
 

-    if (istemp)
+    if (!istemp)     {         /*          * Make an XLOG entry showing the file creation.  If we abort, the file

Fixed, as well as the same bug in RelationTruncate. Thanks for report, 
I'll keep this brown paper bag on for a few days...

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Latest version of Hot Standby patch: unexpected error querying standby
Next
From: Stephen Frost
Date:
Subject: Re: New patch for Column-level privileges