Postgres Pro
Downloads
Home   >   mailing lists

Re: Beginner hacker item: Fix to_reg*() input type - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Beginner hacker item: Fix to_reg*() input type
Date
Msg-id 4946.1452017043@sss.pgh.pa.us
Whole thread Raw
In response to Re: Beginner hacker item: Fix to_reg*() input type  (Petr Korobeinikov <pkorobeinikov@gmail.com>)
Responses Re: Beginner hacker item: Fix to_reg*() input type  (Petr Korobeinikov <pkorobeinikov@gmail.com>)
List pgsql-hackers
Tree view 
Petr Korobeinikov <pkorobeinikov@gmail.com> writes:
>> - Modify the functions in regproc.c. Take a look at how other text input
>> functions work to see what needs to happen here (you'll want to use
>> text_to_cstring() as part of that.)
>> 
>> - Modify the appropriate entries in src/include/catalog/pg_proc.h

> Let me try.
> `make check` says "All 160 tests passed.".

Pushed, thanks!

(I did make some small adjustments --- in this usage, PG_GETARG_TEXT_PP
is good enough and likely a bit more efficient than PG_GETARG_TEXT_P.)
        regards, tom lane

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: bootstrap pg_shseclabel in relcache initialization
Next
From: Tom Lane
Date:
Subject: pg_conversion seems rather strangely defined