Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new
Date
Msg-id 4934059C.2010200@hagander.net
Whole thread Raw
In response to Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new  ("Robert Haas" <robertmhaas@gmail.com>)
Responses Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I could assign it to a variable, but won't the compiler just optimize
that away?

//Magnus

Robert Haas wrote:
> Looks good to me, except for a somewhat excessive number of calls to
> strlen() on the same input data.
> 
> ...Robert
> 
> On Mon, Dec 1, 2008 at 10:31 AM, Magnus Hagander <magnus@hagander.net> wrote:
>> Magnus Hagander wrote:
>>> I think I agree with the idea that we should match wildcards only at the
>>> beginning of the name *for now*, and then see what people actually
>>> request :-) I'm less sure about the single-pathname-component part, but
>>> the argument around backwards compatible is certainly a very valid one..
>> Here's one that (I think) does that. For every step, the code becomes
>> simpler - which I like when it comes to security code :)
>>
>> //Magnus
>>
>>



pgsql-hackers by date:

Previous
From: "Greg Stark"
Date:
Subject: Re: New to_timestamp implementation is pretty strict
Next
From: "Robert Haas"
Date:
Subject: Re: New to_timestamp implementation is pretty strict