Re: Last call for back-branch fixes - Mailing list pgsql-hackers

From Greg Sabino Mullane
Subject Re: Last call for back-branch fixes
Date
Msg-id 4917631f3b4cbf79ae11d41642078416@biglumber.com
Whole thread Raw
In response to Re: Last call for back-branch fixes  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Last call for back-branch fixes
List pgsql-hackers
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


> !                     (void) sprintf((char *) rp, "\\\\%03o", *vp);
> !                     (void) snprintf((char *) rp, 6, "\\\\%03o", *vp); 
> Hardly looks like a critical fix, or even a needed one.  Why bother?

No, not critical. Just something that tripped me up a few months ago when
writing some code based on this section, and I finally remembered it when
I saw your email. It's more of a nice to have, as the surrounding code
should prevent the %03o from making more than 3 characters.

- --
Greg Sabino Mullane greg@turnstep.com
PGP Key: 0x14964AC8 200510032127
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
-----BEGIN PGP SIGNATURE-----

iD8DBQFDQdq9vJuQZxSWSsgRAgeRAKCujcqJFtPf+LSlQ17BBCbGmfelmACgr30s
5OFfHfL3evrwV/FQI/XRMJI=
=ZTcO
-----END PGP SIGNATURE-----




pgsql-hackers by date:

Previous
From: Christopher Kings-Lynne
Date:
Subject: Re: [COMMITTERS] pgsql: Fix procedure for updating nextval() defaults
Next
From: "Marc G. Fournier"
Date:
Subject: New Point Releases Available