Re: plperl needs upgrade for Fedora 10 - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: plperl needs upgrade for Fedora 10
Date
Msg-id 49132FD3.2010904@dunslane.net
Whole thread Raw
In response to Re: plperl needs upgrade for Fedora 10  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: plperl needs upgrade for Fedora 10
List pgsql-hackers

Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>   
>> I'm thinking of something like this change to config/perl.m4:
>>     
>
>   
>> ! if test -z "$perl_embed_ldflags" ; then
>> !       AC_MSG_RESULT(no)
>> !       AC_MSG_ERROR([unable to determine flags to link embedded Perl])
>>     
>
> Hm, is it certain that "empty" is never a valid value for
> $perl_embed_ldflags?  

Yes. If it's empty we don't even link against libperl at all. That can't 
possibly be right.

> In any case I'm a bit confused how this fixes the
> problem --- it looks like the test is just relying on Config not Embed.
>
>             
>   

No, we get the ldopts from Embed and then *remove* the ccldflags from 
Config from that string. What is left is set as perl_embed_flags, and 
that's what mustn't be empty.

cheers

andrew




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: My review for the patch "Table command"
Next
From: Simon Riggs
Date:
Subject: Re: Hot standby v5 patch assertion failure