Re: bug in pageinspect contrib modul - Mailing list pgsql-bugs

From Heikki Linnakangas
Subject Re: bug in pageinspect contrib modul
Date
Msg-id 49004A87.6070406@enterprisedb.com
Whole thread Raw
In response to bug in pageinspect contrib modul  (Zdenek Kotala <Zdenek.Kotala@Sun.COM>)
Responses Re: bug in pageinspect contrib modul  (Zdenek Kotala <Zdenek.Kotala@Sun.COM>)
List pgsql-bugs
Zdenek Kotala wrote:
> The following code is in btreefuncs.c function GetBTPageStatistics:
>
> stat->max_avail = BLCKSZ - (BLCKSZ - phdr->pd_special +
> SizeOfPageHeaderData);
>
> I think it should be:
>
> stat->max_avail = BLCKSZ - (phdr->pd_special + SizeOfPageHeaderData);

Umm, I don't think so. pd_special is the offset to the start of the
special area, so (BLCKSZ - pd_special) is the size of the special area.

However, that max_avail field actually looks like dead code, anyway.

--
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

pgsql-bugs by date:

Previous
From: Zdenek Kotala
Date:
Subject: bug in pageinspect contrib modul
Next
From: Zdenek Kotala
Date:
Subject: Re: Upgrade from 7.4.5 to 8.3.3