Re: FSM rewrite: doc changes - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: FSM rewrite: doc changes
Date
Msg-id 48E1D3EA.10501@enterprisedb.com
Whole thread Raw
In response to Re: FSM rewrite: doc changes  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
>> Tom Lane wrote:
>>> In fsm_rebuild_page, surely we needn't check "if (lchild < NodesPerPage)".
> 
>> Yes, we do.
> 
> But the loop starting point is such that you must be visiting a parent
> with at least one child, no?

Hmm, true, and that means that the comment above it is wrong. I'll 
change the code to do what the comment says. That way, if the page is 
completely garbled, and a parent node with no children has a value other 
than zero, that gets fixed too.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Zdenek Kotala
Date:
Subject: Re: [REVIEW] Prototype: In-place upgrade v02
Next
From: KaiGai Kohei
Date:
Subject: [BUG] pg_ctl restart at the vanilla v8.3.4