Re: [patch] fix dblink security hole - Mailing list pgsql-hackers

From Joe Conway
Subject Re: [patch] fix dblink security hole
Date
Msg-id 48D6FB15.4080409@joeconway.com
Whole thread Raw
In response to Re: [patch] fix dblink security hole  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [patch] fix dblink security hole  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Joe Conway <mail@joeconway.com> writes:
>> If the return value is NULL, use errmsg if you'd like. I'd guess in most 
>> instances you don't even need to bother freeing errmsg as it is in a 
>> limited life memory context.
> 
> Uh, you're confusing the backend environment with libpq's much more
> spartan lifestyle.  errmsg will be malloc'd and it will *not* go away
> unless the caller free()s it.

Yup, just figured that out. Otherwise OK with it?

Joe



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [patch] fix dblink security hole
Next
From: Tom Lane
Date:
Subject: Re: [patch] fix dblink security hole